-
Notifications
You must be signed in to change notification settings - Fork 10
feat(iapp)!: add bulk processing support #234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
PierreJeanjacquot
merged 10 commits into
main
from
feature/iapp-support-bulk-processing
Nov 17, 2025
Merged
feat(iapp)!: add bulk processing support #234
PierreJeanjacquot
merged 10 commits into
main
from
feature/iapp-support-bulk-processing
Nov 17, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c732e8f to
a26430b
Compare
- Move index parameter into params object in processProtectedData - Compute datasetFilename from index inside processProtectedData - Move result.json writing to start function (from processProtectedData) - Change result.txt to result.json for better semantic accuracy - Update bulk processing structure: total-processed → total-count, protected-data-results → results, remove status field - Rename dataset to protected-data in results and error messages - Improve error messages with 'Cause:' prefix for bulk processing errors - Update iexec dependency to ^8.22.0 - Update tests to match new structure
c7e36ed to
ec48f64
Compare
- App always create result files - upon success `result.json` contains `"success": true` (rather than `"status": 200`) - upon failure `result.json` contains `"success": false` and the error message in `"error"`
3fae2e1 to
1fc7455
Compare
…ication success (0b01)
ec6a3c7 to
f785628
Compare
PierreJeanjacquot
approved these changes
Nov 17, 2025
SeddikBellamine
approved these changes
Nov 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for bulk processing
App output
result.jsonchangesCallback changes:
The validation now uses 2 bits to indicate that validation was performed, and the validation result
0x00000000000000000000000000000000000000000000000000000000000000030x00000000000000000000000000000000000000000000000000000000000000020x00000000000000000000000000000000000000000000000000000000000000000x0000000000000000000000000000000000000000000000000000000000000001is supported for backward compatibility, but not producedtests:
BREAKING CHANGE: result file renamed to
result.json; single protectedData result file now contains{"success": <boolean>, "protectedData"?: <address>, "isEmailValid"?: <boolean>, "error"?: <string> }; upon error, the iapp will now exit 0 and output"success": falseand"error": <string>rather than falling the task.BEGIN_COMMIT_OVERRIDE
feat(iapp)!: add bulk processing support (#234)
BREAKING CHANGE: result file renamed to
result.json; single protectedData result file now contains{"success": boolean, "protectedData"?: address, "isEmailValid"?: boolean, "error"?: string }; upon error, the iapp will now exit 0 and output"success": falseand"error": stringrather than falling the task.END_COMMIT_OVERRIDE